debian backports and compiler warnings #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are backported from Debian sl distribution package. Reference: https://packages.debian.org/sid/sl Signed-off-by: Sami Kerola <[email protected]>
These changes are backported from Debian sl distribution package. Reference: https://packages.debian.org/sid/sl Signed-off-by: Sami Kerola <[email protected]>
These changes are backported from Debian sl distribution package. Reference: https://packages.debian.org/sid/sl Signed-off-by: Sami Kerola <[email protected]>
Signed-off-by: Sami Kerola <[email protected]>
Signed-off-by: Sami Kerola <[email protected]>
Signed-off-by: Sami Kerola <[email protected]>
sl-h.c:168:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] sl-h.c:525:25: warning: unused parameter 'c' [-Wunused-parameter] sl-h.c:564:15: warning: variable 'dy' set but not used [-Wunused-but-set-variable] Signed-off-by: Sami Kerola <[email protected]>
In same go remove strlen() call that is unnecessary, sprintf() return value tells how many characters was printed. Signed-off-by: Sami Kerola <[email protected]>
These probably were added to make compiler warnings silent, but that is no longer needed. Signed-off-by: Sami Kerola <[email protected]>
Writing functions in right order is good enough. Signed-off-by: Sami Kerola <[email protected]>
sl-h.c:115:13: warning: 'end_proc' defined but not used [-Wunused-function] Signed-off-by: Sami Kerola <[email protected]>
And remove unnecessary ones. Signed-off-by: Sami Kerola <[email protected]>
All four variables caused same warning. sl.c:60:5: warning: nested extern declaration of 'ACCIDENT' [-Wnested-externs] Signed-off-by: Sami Kerola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three first changes are from Debian sl package, so assuming this pull request is merged the upstream then Debian no longer need to maintain downstream patches.